fix: restore JSON schema generation#117
Merged
joan-anthropic merged 1 commit intomainfrom Oct 27, 2025
Merged
Conversation
asklar
reviewed
Oct 7, 2025
package.json
Outdated
| } | ||
| }, | ||
| "./mcpb-manifest.schema.json": "./dist/mcpb-manifest.schema.json", | ||
| "./mcpb-signature-info.schema.json": "./dist/mcpb-signature-info.schema.json" |
Contributor
There was a problem hiding this comment.
consider also checking in a "last known good" version of the schema, so manifests can refer to it via uri instead of requiring cloning + building
Contributor
Author
There was a problem hiding this comment.
@asklar , would you be able to access those via something like https://unpkg.com? or would they need to be visible in this repo?
Contributor
There was a problem hiding this comment.
if at all possible, we'd prefer to have this in the repo rather than unpkg, as it simplifies SBOM.
bf7e874 to
f7efd3a
Compare
- Refactor JSON schema generation to use zod-to-json-schema - Publish manifest schema to schemas/ directory - Update package.json exports for schema files - Add WIP version 0.3 support - Clean up schema generation scripts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
9b37b1e to
2a0ba89
Compare
MarshallOfSound
approved these changes
Oct 27, 2025
bryan-anthropic
pushed a commit
to bryan-anthropic/mcpb
that referenced
this pull request
Oct 28, 2025
…schema-generation fix: restore JSON schema generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores JSON schema file generation that was broken when we downgraded zod from v4 -> v3 (losing
toJsonSchema) and upon implementing versioned schemas